mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <>
Subject Re: Review Request 29507: Added Configurable Slave Ping Timeouts
Date Thu, 14 May 2015 08:54:19 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 14, 2015, 1:54 a.m.)

Review request for mesos, Ben Mahler and Niklas Nielsen.


Rebased and added configuration/upgrade documentation.

Bugs: MESOS-2110

Repository: mesos


Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to supplement the DEFAULT_SLAVE_PING_TIMEOUT (15secs)
These can be extended if slaves are expected/allowed to be down for
longer than a minute or two.

Slave will receive master's ping timeout in SlaveRe[re]gisteredMessage.
Beware that this affects recovery from network timeouts as well as
actual slave node/process failover.

Diffs (updated)

  docs/ 54c4e31 
  docs/ 2a15694 
  src/master/constants.hpp c386eab 
  src/master/constants.cpp 9ee17e9 
  src/master/flags.hpp 996cf38 
  src/master/flags.cpp 5798989 
  src/master/master.cpp ec32cd6 
  src/messages/messages.proto 98d859f 
  src/slave/constants.hpp fd1c1ab 
  src/slave/constants.cpp 2a99b11 
  src/slave/slave.hpp adb52b5 
  src/slave/slave.cpp 1b17441 
  src/tests/fault_tolerance_tests.cpp 3a27d82 
  src/tests/partition_tests.cpp 1018e47 
  src/tests/slave_recovery_tests.cpp c036e9c 
  src/tests/slave_tests.cpp 04e79ec 



Manually tested slave failover/shutdown with master using different --slave_ping_timeout and
Ran unit tests with shorter non-default values for ping timeouts.
`make check` with new unit tests: ShortPingTimeoutUnreachableMaster and ShortPingTimeoutUnreachableSlave


Adam B

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message