mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr
Date Wed, 13 May 2015 18:36:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34016/#review83651
-----------------------------------------------------------

Ship it!


Thanks! Looks like the title of this review is no longer accurate (since we're not using unique_ptr),
but I'll update that when I get this committed. Also, once the an issue is resolved, you can
mark it as "fixed", which I did for you below. I also added the bug to the review.

- Ben Mahler


On May 13, 2015, 6:36 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34016/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 6:36 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2539
>     https://issues.apache.org/jira/browse/MESOS-2539
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Change the type of signaledWrapper to unique_ptr
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3 
> 
> Diff: https://reviews.apache.org/r/34016/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message