mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 33154: Added reason metrics for slave removals.
Date Wed, 13 May 2015 18:20:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33154/#review83647
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/33154/#comment134656>

    do you still need the copy here?


- Vinod Kone


On May 12, 2015, 11:28 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33154/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 11:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2485
>     https://issues.apache.org/jira/browse/MESOS-2485
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See [MESOS-2485](https://issues.apache.org/jira/browse/MESOS-2485).
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto db4fc8c001dd68bc3b9ca83650170c4f26db18c7 
>   src/master/master.hpp af41216f4a8b81e58916c607a843965aeb4dfb5e 
>   src/master/master.cpp ec32cd655c5a4fded0b682b320a6e0867e4e6468 
>   src/master/metrics.hpp ee3982e38f23b0dcf92d6b1c39b650c3582c16a2 
>   src/master/metrics.cpp 973f0517400786fb16f86914d1d077c88965c9da 
> 
> Diff: https://reviews.apache.org/r/33154/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message