mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 32398: Persisted the reservation state on the slave.
Date Wed, 13 May 2015 18:14:03 GMT


> On May 13, 2015, 6:04 p.m., Jie Yu wrote:
> > I fixed a few style issues for you. Make sure the comments are wrapped at 70 chars
(set tw=70).
> > 
> > Also, this is how I used to find snake case variable names:
> > `/[a-z]*_[a-z]*\ `

> I fixed a few style issues for you.

Thank you... and sorry.
> Make sure the comments are wrapped at 70 chars (set tw=70).

The `set tw=70` should help since I'm a `vim` user myself, but I wonder if all editors have
this capability.
> Also, this is how I used to find snake case variable names: /[a-z]*_[a-z]*\

Oh right, I just realize we actually don't use snake_case for anything in Mesos so I should
be able to regex for it. I think this also means we can probably add this to our style checker.


> On May 13, 2015, 6:04 p.m., Jie Yu wrote:
> > src/tests/reservation_tests.cpp, lines 1026-1027
> > <https://reviews.apache.org/r/32398/diff/6/?file=956697#file956697line1026>
> >
> >     :)

Oh my.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/#review83638
-----------------------------------------------------------


On May 12, 2015, 6:44 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32398/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 6:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-2491
>     https://issues.apache.org/jira/browse/MESOS-2491
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Added `isDynamicallyReserved(resource)` which returns true if the resource is a dynamic
reservation.
> * Added the `isDynamicallyReserved` condition onto `needCheckpointing`.
> * Updated the `applyCheckpointedResources` to consider dynamic reservations.
> * Added tests.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 4c036d36e0e8ab3852786dd32b2d983d45891624 
>   src/common/resources.cpp 235930ff2dbb3ea49a3a0696dc070f2bd56fba4b 
>   src/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 
>   src/tests/reservation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32398/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message