mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.
Date Wed, 13 May 2015 09:19:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review83122
-----------------------------------------------------------


Question about completed tasks/frameworks, and some minor nits.


src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment133989>

    `s/Framework */Framework* /`



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment133990>

    `s/Task */Task* /`



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134583>

    This usage summary makes fwkId and taskId look required. Perhaps `/master/frameworks[/{frameworkId}[/tasks[/{taskId}]]]`?
Or is that too many brackets?



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134584>

    s/filled with the data//



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134589>

    One thing I'm not 100% clear about from this description: Are each of these levels strict
subsets of the json hierarchy, or e.g. is there any data in the result from `/master/frameworks/{fid}`
that is not included in `/master/frameworks`?



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134585>

    s/an invalid one/invalid/



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134587>

    s/provided id/given fid/ (since you use given later)



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134588>

    s/found/Found/



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134590>

    No need for the closing "." on the BadRequest message. None of the other ones have it.



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134592>

    What about completed frameworks? Should they use this endpoint too, or would they get
their own?



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134591>

    framework.isNone()



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134593>

    s/pat/path/



src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment134594>

    Completed tasks?


- Adam B


On May 8, 2015, 3:23 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Marco Massenzio, Niklas Nielsen, and Till
Toenshoff.
> 
> 
> Bugs: MESOS-2157
>     https://issues.apache.org/jira/browse/MESOS-2157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
> 
> Adds tests for the endpoints.
> 
> Works with [29883](https://reviews.apache.org/r/29883).
> 
> Builds on the abandoned patch 14286.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94 
>   src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd 
>   src/master/master.cpp d42a6f321c88ec5d0418264bdda39d083ff54a7e 
>   src/tests/master_tests.cpp bdfccb2427cba938dbbaa8e832255153172b0501 
> 
> Diff: https://reviews.apache.org/r/30612/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message