mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 34128: Enable different IP/Port for external access.
Date Wed, 13 May 2015 00:30:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review83533
-----------------------------------------------------------



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/34128/#comment134536>

    I think we should at least prefix the env variable, like LIBPROCESS_PUBLIC_IP and LIBPROCESS_PUBLIC_PORT
so we don't clash with other env variables from other projects.



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/34128/#comment134539>

    I think overriding __address__ static is dangerous, since we use this variable in other
places for other purposes, such as checking if we are communicating to a remote address, etc.
    
    I suggest we create a local address struct just for binding for listening to public traffic.


- Timothy Chen


On May 12, 2015, 11:23 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34128/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 11:23 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-809
>     https://issues.apache.org/jira/browse/MESOS-809
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose environment variables PUBLIC_IP and PUBLIC_PORT as the IP and
> port which libprocess would advertise (if set). If not set, it defaults to
> the IP and port on which it binded to.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 588bd3e40a0b350ceca15bb8f3f78290ba41d173 
> 
> Diff: https://reviews.apache.org/r/34128/diff/
> 
> 
> Testing
> -------
> 
> Testing:
>   make test
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message