mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.
Date Tue, 12 May 2015 19:18:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/#review83461
-----------------------------------------------------------

Ship it!


Left a minor suggestion but otherwise it looks good to me!


docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/33271/#comment134451>

    Perhaps `s/temporaries/*temporaries*/` to emphasize that it's only temporaries that we
disallow?


- Michael Park


On April 29, 2015, 9:34 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33271/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 9:34 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael Park, and
Till Toenshoff.
> 
> 
> Bugs: MESOS-2629
>     https://issues.apache.org/jira/browse/MESOS-2629
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow up from r32630.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 451d2475e72e07e0a5deec4e62af9d6746d94bc0 
> 
> Diff: https://reviews.apache.org/r/33271/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message