mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 33152: Moved the slave shutdown test into slave_tests.cpp.
Date Tue, 12 May 2015 19:06:22 GMT


> On April 17, 2015, 12:01 p.m., Alexander Rojas wrote:
> > src/tests/slave_tests.cpp, lines 146-148
> > <https://reviews.apache.org/r/33152/diff/1/?file=926674#file926674line146>
> >
> >     One line break too many.

forgot to publish the updated diff?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33152/#review80442
-----------------------------------------------------------


On April 14, 2015, 1:46 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33152/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 1:46 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp a637c32f004638a110390b22cf5b626e904097cf 
>   src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 
> 
> Diff: https://reviews.apache.org/r/33152/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message