mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 29748: Added tests for dynamic reservation.
Date Tue, 12 May 2015 17:15:33 GMT


> On May 11, 2015, 11:32 p.m., Jie Yu wrote:
> > src/tests/reservation_tests.cpp, line 365
> > <https://reviews.apache.org/r/29748/diff/17/?file=954334#file954334line365>
> >
> >     YOu do need a snake_case checker:)

Sigh... Sorry :( Fixed.


> On May 11, 2015, 11:32 p.m., Jie Yu wrote:
> > src/tests/reservation_tests.cpp, lines 399-400
> > <https://reviews.apache.org/r/29748/diff/17/?file=954334#file954334line399>
> >
> >     Hum, have the following 3 tests already been captured in ReserveOperationValidationTest?

Yes, they're captured in the following test cases. What would you like to see done here?

```cpp
TEST_F(ReserveOperationValidationTest, NonMatchingRole)
TEST_F(ReserveOperationValidationTest, NonMatchingPrincipal)
TEST_F(ReserveOperationValidationTest, FrameworkMissingPrincipal)
```


> On May 11, 2015, 11:32 p.m., Jie Yu wrote:
> > src/tests/reservation_tests.cpp, line 944
> > <https://reviews.apache.org/r/29748/diff/17/?file=954334#file954334line944>
> >
> >     2 lines apart between two top level declarations. Please make sure this is the
case in this file.

Fixed.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/#review83313
-----------------------------------------------------------


On May 12, 2015, 5:13 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29748/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 5:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-2489
>     https://issues.apache.org/jira/browse/MESOS-2489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 
>   src/tests/reservation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29748/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message