mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.
Date Tue, 12 May 2015 16:41:02 GMT


> On May 8, 2015, 8:47 a.m., Niklas Nielsen wrote:
> > Kapil, will you be updating this review to use the libprocess event capture instead
of the shared promise?

Kapil: ping


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29947/#review83003
-----------------------------------------------------------


On April 21, 2015, 11:44 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29947/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2226
>     https://issues.apache.org/jira/browse/MESOS-2226
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There is currently no good way to synchronize between the test body and the hook code,
so we wire a promise (owned by the test code). The technical debt is covered by the following
JIRA issue:
> 
> https://issues.apache.org/jira/browse/MESOS-2641
> 
> 
> Diffs
> -----
> 
>   src/examples/test_hook_module.cpp 2f2da1c5ef85af06c7f366d38ce5b64f39d0076f 
>   src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 
> 
> Diff: https://reviews.apache.org/r/29947/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message