mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 33718: Extended documentation on Mesos hooks.
Date Tue, 12 May 2015 06:18:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review83364
-----------------------------------------------------------

Ship it!


Looks great! Sorry I was so slow. Didn't realize it would be so short.


docs/modules.md
<https://reviews.apache.org/r/33718/#comment134341>

    Does it get loaded too by --modules, even if it's not selected by --hooks? If so, I would
say "load it" instead of "introduce it". If not, "introduce" seems like a perfect term.


- Adam B


On May 8, 2015, 4:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33718/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 4:19 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2680
>     https://issues.apache.org/jira/browse/MESOS-2680
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentions necessary flags and adds a usage example.
> 
> 
> Diffs
> -----
> 
>   docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 
> 
> Diff: https://reviews.apache.org/r/33718/diff/
> 
> 
> Testing
> -------
> 
> none: docs update.
> 
> @Adam: as a native speaker, do you mind checking the language?
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message