mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <>
Subject Re: Review Request 32398: Persisted the reservation state on the slave.
Date Sun, 10 May 2015 00:33:09 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 10, 2015, 12:33 a.m.)

Review request for mesos and Alexander Rukletsov.


Rebased, minor updates to the tests, and addressed a few of Jie's comments.

Bugs: MESOS-2491

Repository: mesos


* Added `isDynamicReservation(resource)` which returns true if the resource is either a dynamic
role reservation or a framework reservation.
* Added the `isDynamicReservation` condition onto `needCheckpointing`.
* Updated the `applyCheckpointedResources` to consider dynamic reservations.
* Added tests.

Diffs (updated)

  include/mesos/resources.hpp 4c036d36e0e8ab3852786dd32b2d983d45891624 
  src/common/resources.cpp 235930ff2dbb3ea49a3a0696dc070f2bd56fba4b 
  src/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 
  src/tests/reservation_tests.cpp PRE-CREATION 



make check


Michael Park

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message