mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <>
Subject Re: Review Request 31667: Piped hashmap<SlaveID, Resources> from allocator through to sorter.
Date Sun, 10 May 2015 00:21:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 10, 2015, 12:21 a.m.)

Review request for mesos, Alexander Rukletsov and Ben Mahler.


Erase the `SlaveID` keys once the resources get to empty.

Bugs: MESOS-2373

Repository: mesos


`Sorter` changes:

- Augmented `add`, `remove`, `allocated`, `unallocated`, `update` with `SlaveID`.
- `allocation` returns `hashmap<SlaveID, Resources>`.

`DRFSorter` changes:

- `allocations` is updated from `hashmap<std::string, Resources>` to `hashmap<std::string,
hashmap<SlaveID, Resources>>`.
- `resources` is updated from `Resources` to `hashmap<SlaveID, Resources>`.

Diffs (updated)

  src/master/allocator/mesos/hierarchical.hpp 09adced9d8712b3eeda885d598443791186890db 
  src/master/allocator/sorter/drf/sorter.hpp 4366710d6530b784aa5094813328d0e338239ba0 
  src/master/allocator/sorter/drf/sorter.cpp 2f69f384b95ff20d3ee429a4570a8cffa74d8e8b 
  src/master/allocator/sorter/sorter.hpp e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b 
  src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd 



make check


Michael Park

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message