mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 33490: Avoid adding duplicate tasks
Date Fri, 08 May 2015 18:16:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33490/
-----------------------------------------------------------

(Updated May 8, 2015, 6:16 p.m.)


Review request for mesos, Adam B and Joris Van Remoortere.


Repository: mesos


Description (updated)
-------

In `Framework::addCompletedTask(const Task& task)` we did not check
for duplicated tasks, so they could be added more than once.

A simple check has now been added (there is the question of whether the `operator ==` on `Task`
is too strict, so as
never to cause a match).

This fixes a TODO I came across as part of the work on MESOS-2633 (no Jira tracking this issue)


Diffs
-----

  src/master/framework.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/33490/diff/


Testing (updated)
-------

make check


Thanks,

Marco Massenzio


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message