mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 33765: MESOS-2665: fix queuing discipline wrapper in linux/routing/queueing
Date Fri, 08 May 2015 18:16:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33765/#review83036
-----------------------------------------------------------


This patch does many stuffs. Could you please split this patches into multiple smaller patches
so that it's easier for the reviewers. For example, the first patch can just be merging queueing::Handle
and filter::Handle.

- Jie Yu


On May 1, 2015, 7:24 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33765/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 7:24 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: mesos-2665
>     https://issues.apache.org/jira/browse/mesos-2665
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-2665: fix queuing discipline wrapper in linux/routing/queueing
> 
> * refactor routing Handles to eliminate the duplicated defintions in queueing and filter
> * modify the create functions to return a handle to the new discipline
> * correct the search funtion to filter by discipline and extend to allow filtering by
handle and parent 
> * extend the test cases to match
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/filter/arp.hpp fa0ea6f93218fb3bee9f435f0268022d5edc5e11 
>   src/linux/routing/filter/arp.cpp bf19264ccc83e8a8b8c2affe53779ac070472925 
>   src/linux/routing/filter/filter.hpp d4ea099a2e35ffc0e6d560c5de9864dbbfe10038 
>   src/linux/routing/filter/handle.hpp 190177441bc95cf77690dbdeca189a816c6e2324 
>   src/linux/routing/filter/icmp.hpp 431bc19eb600b0568874dacfce123adef0f9ff0b 
>   src/linux/routing/filter/icmp.cpp 706b5d1871d9e0b79d1b869d27d0e87112b75975 
>   src/linux/routing/filter/internal.hpp 8a6c0c0390c4ed119a11f0f808e0a244f7734c45 
>   src/linux/routing/filter/ip.hpp b5406024fdbfd1510bcf619f04a7369763396e72 
>   src/linux/routing/filter/ip.cpp de6407119c6726e0f32b07fd6ff61fa29262638b 
>   src/linux/routing/handle.hpp PRE-CREATION 
>   src/linux/routing/queueing/fq_codel.hpp 4f67ab7d64afea96a07dfcf36769a9c667749a00 
>   src/linux/routing/queueing/fq_codel.cpp 02ad8df7814c0e549a9ca9aef39777684e6abdcb 
>   src/linux/routing/queueing/handle.hpp 2725d0794ca29ad5dc1b0148d0f68b90ce8b8369 
>   src/linux/routing/queueing/ingress.hpp b323a7f6daed828327d6d9e9740df81582e0ba2b 
>   src/linux/routing/queueing/ingress.cpp 47c73376097d70819defdee31a6d1e446df6b8ba 
>   src/linux/routing/queueing/internal.hpp 7c6c4d3d960b9a4bf44dcf482212317522353d69 
>   src/slave/containerizer/isolators/network/port_mapping.cpp fc0fa4c2086f0be84ab7ddc04b85dec4a3b5b5dc

>   src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 
>   src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba 
> 
> Diff: https://reviews.apache.org/r/33765/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message