mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 31504: Add a basic filter to match all packets
Date Thu, 07 May 2015 23:20:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504/
-----------------------------------------------------------

(Updated May 7, 2015, 11:20 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.


Changes
-------

Address review comments


Bugs: MESOS-2422
    https://issues.apache.org/jira/browse/MESOS-2422


Repository: mesos


Description
-------

We need a default filter which has the lowest priority and can match all packets that are
not matched by the previous filters, so that no packet will escape (otherwise it would be
dropped by fq_codel). Because basic filter can accept protocol as a parameter, the arp filter
which is based on basic can move to this as well.


Diffs (updated)
-----

  src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
  src/linux/routing/filter/basic.hpp PRE-CREATION 
  src/linux/routing/filter/basic.cpp PRE-CREATION 
  src/tests/routing_tests.cpp ce583b59bf9fb2ef855aa82ab6083ea11b138e55 

Diff: https://reviews.apache.org/r/31504/diff/


Testing
-------

Run the testcase.


Thanks,

Cong Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message