mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 31504: Add a basic filter to match all packets
Date Thu, 07 May 2015 22:31:20 GMT


> On May 7, 2015, 10:03 p.m., Jie Yu wrote:
> > src/linux/routing/filter/basic.cpp, lines 95-98
> > <https://reviews.apache.org/r/31504/diff/5/?file=950511#file950511line95>
> >
> >     Should you pass a `protocol` as well to the `exists` function?
> >     
> >     ```
> >     Try<bool> exists(link, parent, uint16_t protocol)
> >     {
> >       return internal::exists(link, parent, Classifier(protocol));
> >     }
> >     ```
> 
> Cong Wang wrote:
>     That is what I plan to do when we move ARP filter on top of basic filter, so before
we do that we don't need to pass protocol?
> 
> Jie Yu wrote:
>     IC, but that's pretty straight forward to do to me. So probably just do that in this
patch?

Or you have the next patch ready and I'll commit both of them togeter.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504/#review82918
-----------------------------------------------------------


On May 5, 2015, 6:37 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31504/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 6:37 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2422
>     https://issues.apache.org/jira/browse/MESOS-2422
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We need a default filter which has the lowest priority and can match all packets that
are not matched by the previous filters, so that no packet will escape (otherwise it would
be dropped by fq_codel). Because basic filter can accept protocol as a parameter, the arp
filter which is based on basic can move to this as well.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/linux/routing/filter/basic.hpp PRE-CREATION 
>   src/linux/routing/filter/basic.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp ce583b59bf9fb2ef855aa82ab6083ea11b138e55 
> 
> Diff: https://reviews.apache.org/r/31504/diff/
> 
> 
> Testing
> -------
> 
> Run the testcase.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message