mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 31504: Add a basic filter to match all packets
Date Thu, 07 May 2015 22:03:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504/#review82918
-----------------------------------------------------------



src/linux/routing/filter/basic.hpp
<https://reviews.apache.org/r/31504/#comment133751>

    s/struct/class
    
    Make the member field `procotol_` private and the rest `public`.



src/linux/routing/filter/basic.hpp
<https://reviews.apache.org/r/31504/#comment133750>

    We don't use const ref for primitive types (e.g., int, double, etc.).
    
    ```
    explicit Classifier(uint16_t _protocol)
    ```



src/linux/routing/filter/basic.hpp
<https://reviews.apache.org/r/31504/#comment133752>

    Please adjust the comments.
    
    "set the classid for packets."



src/linux/routing/filter/basic.cpp
<https://reviews.apache.org/r/31504/#comment133764>

    Should you pass a `protocol` as well to the `exists` function?
    
    ```
    Try<bool> exists(link, parent, uint16_t protocol)
    {
      return internal::exists(link, parent, Classifier(protocol));
    }
    ```



src/linux/routing/filter/basic.cpp
<https://reviews.apache.org/r/31504/#comment133765>

    Ditto. Please pass in a `protocol`



src/linux/routing/filter/basic.cpp
<https://reviews.apache.org/r/31504/#comment133766>

    Ditto here.


- Jie Yu


On May 5, 2015, 6:37 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31504/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 6:37 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2422
>     https://issues.apache.org/jira/browse/MESOS-2422
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We need a default filter which has the lowest priority and can match all packets that
are not matched by the previous filters, so that no packet will escape (otherwise it would
be dropped by fq_codel). Because basic filter can accept protocol as a parameter, the arp
filter which is based on basic can move to this as well.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/linux/routing/filter/basic.hpp PRE-CREATION 
>   src/linux/routing/filter/basic.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp ce583b59bf9fb2ef855aa82ab6083ea11b138e55 
> 
> Diff: https://reviews.apache.org/r/31504/diff/
> 
> 
> Testing
> -------
> 
> Run the testcase.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message