mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 33643: Add EMPTY to stout hashset
Date Thu, 07 May 2015 21:57:09 GMT


> On May 6, 2015, 12:52 a.m., Cody Maloney wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp, line 75
> > <https://reviews.apache.org/r/33643/diff/3/?file=950611#file950611line75>
> >
> >     Any reason we can't do this as a function with a static in it? Solves the destruction
order issues, doesn't leak, doesn't require the constant reference.

We're going to leak the constant for now (as we've done lots of other places already) as we
work out MESOS-2694.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33643/#review82624
-----------------------------------------------------------


On May 5, 2015, 9:50 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33643/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 9:50 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp d2b74393b7c4b65477698d9c810dfe3c8673c2ab

> 
> Diff: https://reviews.apache.org/r/33643/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message