mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 33918: Added resources estimator abstraction for oversubscription.
Date Thu, 07 May 2015 16:57:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33918/#review82829
-----------------------------------------------------------

Ship it!


Looks good! I agree with Vinod about the naming, but apart from that (and the comments below):
Shipit!


include/mesos/slave/resources_estimator.hpp
<https://reviews.apache.org/r/33918/#comment133669>

    A comment here about the component and how it fits in the whole system would be great
:)



include/mesos/slave/resources_estimator.hpp
<https://reviews.apache.org/r/33918/#comment133670>

    Nice!



src/slave/resources_estimator.cpp
<https://reviews.apache.org/r/33918/#comment133663>

    How about adding a bit more context? For example: "Resource estimator not yet initialized"?



src/slave/resources_estimator.cpp
<https://reviews.apache.org/r/33918/#comment133664>

    Shouldn't we be able to start the process in the constructor and forward initialize()
to the process here?



src/slave/resources_estimator.cpp
<https://reviews.apache.org/r/33918/#comment133662>

    Same here?


- Niklas Nielsen


On May 6, 2015, 3:35 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33918/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 3:35 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, and Vinod
Kone.
> 
> 
> Bugs: MESOS-2649
>     https://issues.apache.org/jira/browse/MESOS-2649
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added resources estimator abstraction for oversubscription.
> 
> This patch defines the interface of the resources estimator and creates a default stub
implementation.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/resources_estimator.hpp PRE-CREATION 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/slave/resources_estimator.hpp PRE-CREATION 
>   src/slave/resources_estimator.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33918/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message