mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 33875: Removed unused collect cycle in resource monitor
Date Wed, 06 May 2015 17:56:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33875/#review82701
-----------------------------------------------------------



src/slave/monitor.hpp
<https://reviews.apache.org/r/33875/#comment133488>

    Could you please update the comments as well?



src/slave/monitor.hpp
<https://reviews.apache.org/r/33875/#comment133489>

    This does not sound valid anymore.



src/slave/monitor.hpp
<https://reviews.apache.org/r/33875/#comment133490>

    Can you remove this as well? We might want to still keep the slave flag resource_monitoring_interval
because otherwise it'll break someone's startup script. Could you please add a TODO there
to deprecate the flag.



src/slave/monitor.cpp
<https://reviews.apache.org/r/33875/#comment133491>

    No needed anymore?


- Jie Yu


On May 6, 2015, 4:01 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33875/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 4:01 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/slave/monitor.hpp 69c60a10187f8ea617c6be9738b28e8103e0ed27 
>   src/slave/monitor.cpp 398af010564e999b46e38560ba1e652261a9420c 
>   src/tests/monitor_tests.cpp 899af4449140dd787cfe829c010f94b52e98937b 
> 
> Diff: https://reviews.apache.org/r/33875/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message