mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 33733: Fixed style error with template definitions withing common/parse.hpp
Date Tue, 05 May 2015 21:41:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33733/#review82585
-----------------------------------------------------------

Ship it!


Could you fill us in on the reasoning and/or update the styleguide for this? Thanks a bunch
:)

- Till Toenshoff


On April 30, 2015, 10:45 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33733/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 10:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joerg Schad, Michael Park, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaces every instance of `template<>` to `template <>` in the file `src/common/parse.hpp`
> 
> 
> Diffs
> -----
> 
>   src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc 
> 
> Diff: https://reviews.apache.org/r/33733/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message