mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.
Date Tue, 05 May 2015 01:22:05 GMT


> On May 5, 2015, 12:45 a.m., Adam B wrote:
> > configure.ac, line 569
> > <https://reviews.apache.org/r/33828/diff/1/?file=949264#file949264line569>
> >
> >     Style nit: Any reason you went with `+=` instead of `CXXFLAGS="${CXXFLAGS} -Wno-maybe-uninitialized"`
like the rest of the file?

Went ahead and fixed this.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33828/#review82464
-----------------------------------------------------------


On May 4, 2015, 11:48 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33828/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Cody Maloney.
> 
> 
> Bugs: MESOS-2690
>     https://issues.apache.org/jira/browse/MESOS-2690
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See Summary.
> 
> 
> Diffs
> -----
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
> 
> Diff: https://reviews.apache.org/r/33828/diff/
> 
> 
> Testing
> -------
> 
> Built on gcc 4.9 with --enable-optimize. Verified the compilation warnings are gone.
> Would love someone to confirm this does not break the clang builds.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message