mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 29889: Recover Docker containers when mesos slave is in a container
Date Mon, 04 May 2015 20:52:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review82426
-----------------------------------------------------------


General comment: the _launch, __launch, ___launch, etc. cascade is still a bit hard to follow
through. I wonder if we can find another style for this eventually. But this does not have
to be part of this review.


src/slave/containerizer/docker.hpp
<https://reviews.apache.org/r/29889/#comment133154>

    Can you please put comments before every *{_}launch method explining roughly what it does?
That would help since none of these have descriptive names.



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29889/#comment133153>

    Is the comment stale? This seems to start the Docker executor.



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29889/#comment133155>

    Can't use trailing underscore for a local.
    
    Which container is this now?



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment133157>

    s/container/inspect



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment133159>

    Can we make this wait loop a subroutine for reuse?



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment133158>

    s/container/inspect



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment133160>

    30 seconds - magic number? global constant?



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment133162>

    TODO: come up with a plan to not depend on external dependencies?



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment133169>

    s/container/inspect
    
    Or maybe call this without temp var?



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment133170>

    Same magical 30 as above. global constant?



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment133173>

    Is it possible to not rely on dependencies outside the Mesos repo? If so, can we have
a TODO here?


- Bernd Mathiske


On May 2, 2015, 1:22 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> -----------------------------------------------------------
> 
> (Updated May 2, 2015, 1:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2115
>     https://issues.apache.org/jira/browse/MESOS-2115
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a one mega patch and contains many reviews that's already on rb.
> 
> This review is not meant to be merged, only provided for easier review.
> 
> 
> Diffs
> -----
> 
>   Dockerfile 35abf25 
>   docs/configuration.md 54c4e31 
>   docs/docker-containerizer.md a5438b7 
>   src/Makefile.am 93c7c8a 
>   src/docker/docker.hpp 3ebbc1f 
>   src/docker/docker.cpp 3a485a2 
>   src/docker/executor.cpp PRE-CREATION 
>   src/slave/constants.hpp fd1c1ab 
>   src/slave/constants.cpp 2a99b11 
>   src/slave/containerizer/docker.hpp b25ec55 
>   src/slave/containerizer/docker.cpp f9fc89a 
>   src/slave/flags.hpp d3b1ce1 
>   src/slave/flags.cpp d0932b0 
>   src/tests/docker_containerizer_tests.cpp c9d66b3 
> 
> Diff: https://reviews.apache.org/r/29889/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message