mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.
Date Sat, 02 May 2015 17:15:17 GMT


> On April 26, 2015, 8:52 p.m., Michael Park wrote:
> > docs/mesos-c++-style-guide.md, lines 214-221
> > <https://reviews.apache.org/r/33558/diff/3/?file=942044#file942044line214>
> >
> >     Was this really intended to be marked `OK`? It doesn't look like a style we'll
want to use to me.

Yes, I marked this as OK because of the version where 'socket.send(' is actually just a single
function call like 'function(', I've updated the guide with this example and point to preferring
the version that doesn't do it this way.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33558/#review81643
-----------------------------------------------------------


On April 28, 2015, 5:33 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33558/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 5:33 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-2669
>     https://issues.apache.org/jira/browse/MESOS-2669
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary. Note that there will be a follow up review which enacts this style in the
code base.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md fe98f90ad0b0f5dd38af97e85062e90cee8de99e 
> 
> Diff: https://reviews.apache.org/r/33558/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message