mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cody Maloney" <c...@mesosphere.io>
Subject Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing
Date Fri, 01 May 2015 19:30:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33752/#review82272
-----------------------------------------------------------


Overall looks good to me. Should have Tim St. Clair [~tstclair] review as he's the autotools
guru.


configure.ac
<https://reviews.apache.org/r/33752/#comment132994>

    I worry this changes the behavior some when --disable-bundled is set (Previously it seems
like it would see if it could find the package locally, and if not enable the bundled one).
Internally we don't really use that codepath though.


- Cody Maloney


On May 1, 2015, 3:42 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33752/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos and Cody Maloney.
> 
> 
> Bugs: MESOS-2537
>     https://issues.apache.org/jira/browse/MESOS-2537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In a number of places, the Mesos configure script passes "$foo=yes"
> to the 2nd argument of AC_ARG_ENABLED. However, the 2nd argument
> is invoked when the option is provided in any form, not just when
> the --enable-foo form is used. One result of this is that
> --disable-optimize doesn't work.
> 
> The correct handling of the 2nd argument is to save the value of
> "$enableval". This change sets the value of all the enable variables
> using $enableval, and sets the default value based on the option
> name.
> 
> There are a number of enable options that were internally named
> "$with_foo" and "$without_foo". Rename these to "$enable_foo" for
> clarity and to remove the need for both a with_ and a without_
> version.
> 
> Finally, emit the compilation flags at the end of the configure
> phase so it is easier to see the results of your configuration
> options.
> 
> 
> Diffs
> -----
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
> 
> Diff: https://reviews.apache.org/r/33752/diff/
> 
> 
> Testing
> -------
> 
> Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify that the status summary
reflects the expected compiler flags. Verify that --enable-foo and --disable-foo do different
things.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message