mesos-reviews mailing list archives: April 2015

Site index · List index
Message list« Previous · 1 · 2 · 3 · Next »Thread · Author · Date
Re: Review Request 32999: Added a document for engineering principles and practices.
Ben Mahler   Re: Review Request 32999: Added a document for engineering principles and practices. Thu, 23 Apr, 23:04
Ben Mahler   Re: Review Request 32999: Added a document for engineering principles and practices. Thu, 23 Apr, 23:15
Mesos ReviewBot     Re: Review Request 32999: Added a document for engineering principles and practices. Thu, 23 Apr, 23:48
Re: Review Request 32998: Split committer's guide into code reviewing and committing documents.
Ben Mahler   Re: Review Request 32998: Split committer's guide into code reviewing and committing documents. Thu, 23 Apr, 23:06
Ben Mahler   Re: Review Request 32998: Split committer's guide into code reviewing and committing documents. Thu, 23 Apr, 23:06
Ben Mahler   Re: Review Request 32998: Split committer's guide into code reviewing and committing documents. Thu, 23 Apr, 23:06
Ben Mahler   Re: Review Request 32998: Split committer's guide into code reviewing and committing documents. Thu, 23 Apr, 23:06
Re: Review Request 28257: Allow prefix paths in libprocess
Cody Maloney   Re: Review Request 28257: Allow prefix paths in libprocess Thu, 23 Apr, 23:32
Re: Review Request 32982: Added reservation user guide.
Alexander Rukletsov   Re: Review Request 32982: Added reservation user guide. Fri, 24 Apr, 08:17
Re: Review Request 32398: Persisted the reservation state on the slave.
Alexander Rukletsov   Re: Review Request 32398: Persisted the reservation state on the slave. Fri, 24 Apr, 08:18
Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message.
Alexander Rukletsov   Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message. Fri, 24 Apr, 08:19
Michael Park     Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message. Mon, 27 Apr, 17:26
Alexander Rukletsov     Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message. Tue, 28 Apr, 07:01
Michael Park   Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message. Mon, 27 Apr, 17:15
Re: Review Request 32536: Updated variable naming style.
Alexander Rukletsov   Re: Review Request 32536: Updated variable naming style. Fri, 24 Apr, 13:27
Mesos ReviewBot     Re: Review Request 32536: Updated variable naming style. Fri, 24 Apr, 14:10
Benjamin Hindman     Re: Review Request 32536: Updated variable naming style. Sun, 26 Apr, 02:07
Benjamin Hindman       Re: Review Request 32536: Updated variable naming style. Sun, 26 Apr, 02:17
Alexander Rukletsov       Re: Review Request 32536: Updated variable naming style. Mon, 27 Apr, 08:33
Marco Massenzio         Re: Review Request 32536: Updated variable naming style. Mon, 27 Apr, 18:00
Re: Review Request 32001: Required a period in trailing comments in the style guide.
Alexander Rukletsov   Re: Review Request 32001: Required a period in trailing comments in the style guide. Fri, 24 Apr, 13:52
Mesos ReviewBot   Re: Review Request 32001: Required a period in trailing comments in the style guide. Fri, 24 Apr, 15:09
Till Toenshoff   Re: Review Request 32001: Required a period in trailing comments in the style guide. Sun, 26 Apr, 23:43
Re: Review Request 33040: Expose qdisc statistics from libnl
Paul Brett   Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 17:46
Mesos ReviewBot     Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 18:04
Jie Yu     Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 18:09
Paul Brett       Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 18:41
Jie Yu       Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 19:25
Paul Brett     Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 19:28
Mesos ReviewBot       Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 20:11
Cong Wang       Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 20:13
Cong Wang       Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 20:16
Cong Wang       Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 20:18
Chi Zhang       Re: Review Request 33040: Expose qdisc statistics from libnl Fri, 24 Apr, 22:53
Review Request 33527: Updated documentation for ClangFormat.
Michael Park   Review Request 33527: Updated documentation for ClangFormat. Fri, 24 Apr, 18:22
Mesos ReviewBot     Re: Review Request 33527: Updated documentation for ClangFormat. Fri, 24 Apr, 18:50
Till Toenshoff   Re: Review Request 33527: Updated documentation for ClangFormat. Sun, 26 Apr, 17:12
Michael Park   Re: Review Request 33527: Updated documentation for ClangFormat. Sun, 26 Apr, 21:59
Mesos ReviewBot     Re: Review Request 33527: Updated documentation for ClangFormat. Sun, 26 Apr, 22:39
Review Request 33528: Create '.clang-format' from 'bootstrap' script instead.
Michael Park   Review Request 33528: Create '.clang-format' from 'bootstrap' script instead. Fri, 24 Apr, 18:22
Mesos ReviewBot     Re: Review Request 33528: Create '.clang-format' from 'bootstrap' script instead. Fri, 24 Apr, 19:33
Till Toenshoff   Re: Review Request 33528: Create '.clang-format' from 'bootstrap' script instead. Sun, 26 Apr, 22:17
Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332)
Paul Brett   Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332) Fri, 24 Apr, 19:39
Paul Brett   Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332) Fri, 24 Apr, 19:42
Chi Zhang     Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332) Sat, 25 Apr, 01:03
Chi Zhang     Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332) Sat, 25 Apr, 01:06
Re: Review Request 33412: Made the launcher recover interface to return a set of orphan containers.
Ian Downes   Re: Review Request 33412: Made the launcher recover interface to return a set of orphan containers. Fri, 24 Apr, 19:39
Re: Review Request 33413: Changed the isolator recover interface to take a set of orphan containers detected by the launcher.
Ian Downes   Re: Review Request 33413: Changed the isolator recover interface to take a set of orphan containers detected by the launcher. Fri, 24 Apr, 19:40
Re: Review Request 33414: Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.
Ian Downes   Re: Review Request 33414: Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails. Fri, 24 Apr, 19:40
Jie Yu     Re: Review Request 33414: Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails. Fri, 24 Apr, 23:34
Re: Review Request 33415: Changed launchers and isolators to adapt to the new orphan cleanup semantics.
Ian Downes   Re: Review Request 33415: Changed launchers and isolators to adapt to the new orphan cleanup semantics. Fri, 24 Apr, 19:40
Re: Review Request 33339: Add a Java example framework to test persistent volumes.
haosdent huang   Re: Review Request 33339: Add a Java example framework to test persistent volumes. Sat, 25 Apr, 10:17
haosdent huang     Re: Review Request 33339: Add a Java example framework to test persistent volumes. Sat, 25 Apr, 13:23
haosdent huang       Re: Review Request 33339: Add a Java example framework to test persistent volumes. Sat, 25 Apr, 13:25
haosdent huang         Re: Review Request 33339: Add a Java example framework to test persistent volumes. Sat, 25 Apr, 18:05
haosdent huang           Re: Review Request 33339: Add a Java example framework to test persistent volumes. Sat, 25 Apr, 18:07
Mesos ReviewBot             Re: Review Request 33339: Add a Java example framework to test persistent volumes. Sat, 25 Apr, 18:49
haosdent huang             Re: Review Request 33339: Add a Java example framework to test persistent volumes. Sun, 26 Apr, 07:10
haosdent huang Review Request 33554: Avoid Python declineOffer raise exception when filters is assigned to None explicitly Sat, 25 Apr, 20:09
Mesos ReviewBot   Re: Review Request 33554: Avoid Python declineOffer raise exception when filters is assigned to None explicitly Sat, 25 Apr, 20:49
Benjamin Hindman Review Request 33558: Add C++11 lambdas to the C++ style guide. Sun, 26 Apr, 01:23
Mesos ReviewBot   Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Sun, 26 Apr, 02:02
Michael Park   Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Sun, 26 Apr, 03:51
Benjamin Hindman     Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Sun, 26 Apr, 20:26
Benjamin Hindman   Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Sun, 26 Apr, 20:18
Benjamin Hindman     Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Sun, 26 Apr, 20:26
Mesos ReviewBot       Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Sun, 26 Apr, 20:52
Michael Park       Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Sun, 26 Apr, 20:52
Ben Mahler       Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Tue, 28 Apr, 02:08
Michael Park         Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Tue, 28 Apr, 04:21
Ben Mahler         Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Tue, 28 Apr, 04:32
Benjamin Hindman       Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Tue, 28 Apr, 17:34
Joris Van Remoortere         Re: Review Request 33558: Add C++11 lambdas to the C++ style guide. Wed, 29 Apr, 21:18
Michael Park Review Request 33560: stout: Removed pre-C++11 codepath. Sun, 26 Apr, 07:02
Benjamin Hindman   Re: Review Request 33560: stout: Removed pre-C++11 codepath. Sun, 26 Apr, 19:38
Michael Park Review Request 33561: libprocess: Removed pre-C++11 codepath. Sun, 26 Apr, 07:02
Benjamin Hindman   Re: Review Request 33561: libprocess: Removed pre-C++11 codepath. Sun, 26 Apr, 19:39
Michael Park Review Request 33562: mesos: Removed pre-C++11 codepath. Sun, 26 Apr, 07:02
Benjamin Hindman   Re: Review Request 33562: mesos: Removed pre-C++11 codepath. Sun, 26 Apr, 19:39
Michael Park Review Request 33564: stout: Removed <stout/memory.hpp> and switched from 'memory::' to 'std::'. Sun, 26 Apr, 07:12
Benjamin Hindman   Re: Review Request 33564: stout: Removed <stout/memory.hpp> and switched from 'memory::' to 'std::'. Sun, 26 Apr, 19:39
Michael Park Review Request 33565: libprocess: Removed <stout/memory.hpp> and switched from memory:: to std::. Sun, 26 Apr, 07:12
Benjamin Hindman   Re: Review Request 33565: libprocess: Removed <stout/memory.hpp> and switched from memory:: to std::. Sun, 26 Apr, 19:39
Michael Park Review Request 33566: mesos: Removed <stout/memory.hpp> and switched from memory:: to std::. Sun, 26 Apr, 07:12
Benjamin Hindman   Re: Review Request 33566: mesos: Removed <stout/memory.hpp> and switched from memory:: to std::. Sun, 26 Apr, 19:39
Michael Park Review Request 33567: stout: Removed <stout/tuple.hpp> and switched from tuples:: to std::. Sun, 26 Apr, 07:14
Benjamin Hindman   Re: Review Request 33567: stout: Removed <stout/tuple.hpp> and switched from tuples:: to std::. Sun, 26 Apr, 19:39
Michael Park Review Request 33568: libprocess: Removed <stout/tuple.hpp> and switched from tuples:: to std::. Sun, 26 Apr, 07:14
Benjamin Hindman   Re: Review Request 33568: libprocess: Removed <stout/tuple.hpp> and switched from tuples:: to std::. Sun, 26 Apr, 19:39
Michael Park Review Request 33569: mesos: Removed <stout/tuple.hpp> and switched from tuples:: to std::. Sun, 26 Apr, 07:14
Mesos ReviewBot   Re: Review Request 33569: mesos: Removed <stout/tuple.hpp> and switched from tuples:: to std::. Sun, 26 Apr, 07:49
Benjamin Hindman   Re: Review Request 33569: mesos: Removed <stout/tuple.hpp> and switched from tuples:: to std::. Sun, 26 Apr, 19:39
Benjamin Hindman Review Request 33572: Add C++11 unrestricted union to the C++ style guide. Sun, 26 Apr, 20:19
Benjamin Hindman   Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide. Sun, 26 Apr, 20:26
Michael Park     Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide. Sun, 26 Apr, 20:33
Michael Park     Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide. Mon, 27 Apr, 04:51
Joris Van Remoortere       Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide. Wed, 29 Apr, 21:47
Ben Mahler     Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide. Tue, 28 Apr, 21:03
Joris Van Remoortere     Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide. Wed, 29 Apr, 21:51
Re: Review Request 33266: Check patch command in configure.ac
Till Toenshoff   Re: Review Request 33266: Check patch command in configure.ac Mon, 27 Apr, 00:01
Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent.
Joerg Schad   Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent. Mon, 27 Apr, 04:50
Michael Park     Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent. Mon, 27 Apr, 04:52
Mesos ReviewBot     Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent. Mon, 27 Apr, 05:29
Joerg Schad   Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent. Mon, 27 Apr, 04:51
Re: Review Request 32108: Added manual make for readability training source code
Bernd Mathiske   Re: Review Request 32108: Added manual make for readability training source code Tue, 28 Apr, 01:44
Mesos ReviewBot     Re: Review Request 32108: Added manual make for readability training source code Tue, 28 Apr, 02:06
Alexander Rukletsov     Re: Review Request 32108: Added manual make for readability training source code Tue, 28 Apr, 07:15
Bernd Mathiske       Re: Review Request 32108: Added manual make for readability training source code Tue, 28 Apr, 22:35
Bernd Mathiske     Re: Review Request 32108: Added manual make for readability training source code. Tue, 28 Apr, 22:36
Bernd Mathiske       Re: Review Request 32108: Added manual make for readability training source code. Thu, 30 Apr, 20:23
Jie Yu Review Request 33631: Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery. Tue, 28 Apr, 17:55
Chi Zhang   Re: Review Request 33631: Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery. Tue, 28 Apr, 18:06
Ian Downes   Re: Review Request 33631: Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery. Tue, 28 Apr, 18:07
Mesos ReviewBot   Re: Review Request 33631: Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery. Tue, 28 Apr, 18:40
Chi Zhang Review Request 33644: MemoryTestHelper: Changed to do memset before mlock. Tue, 28 Apr, 23:00
Jie Yu   Re: Review Request 33644: MemoryTestHelper: Changed to do memset before mlock. Tue, 28 Apr, 23:18
Mesos ReviewBot   Re: Review Request 33644: MemoryTestHelper: Changed to do memset before mlock. Tue, 28 Apr, 23:40
Ian Downes Review Request 33647: Only log processes in the slave cgroup on recovery. Tue, 28 Apr, 23:33
Jie Yu   Re: Review Request 33647: Only log processes in the slave cgroup on recovery. Tue, 28 Apr, 23:38
Ian Downes   Re: Review Request 33647: Only log processes in the slave cgroup on recovery. Tue, 28 Apr, 23:47
Ian Downes     Re: Review Request 33647: Only log processes in the slave cgroup on recovery. Tue, 28 Apr, 23:48
Timothy Chen       Re: Review Request 33647: Only log processes in the slave cgroup on recovery. Tue, 28 Apr, 23:49
Re: Review Request 30774: Fetcher Cache
Bernd Mathiske   Re: Review Request 30774: Fetcher Cache Wed, 29 Apr, 20:42
Benjamin Hindman     Re: Review Request 30774: Fetcher Cache Wed, 29 Apr, 20:46
Benjamin Hindman     Re: Review Request 30774: Fetcher Cache Wed, 29 Apr, 22:41
Re: Review Request 32630: Add style change proposal for constant reference to temporaries.
Joris Van Remoortere   Re: Review Request 32630: Add style change proposal for constant reference to temporaries. Wed, 29 Apr, 20:43
Re: Review Request 33646: [Proposal] Follow Google Style Guide for include order completely.
Joerg Schad   Re: Review Request 33646: [Proposal] Follow Google Style Guide for include order completely. Wed, 29 Apr, 20:50
Mesos ReviewBot     Re: Review Request 33646: [Proposal] Follow Google Style Guide for include order completely. Wed, 29 Apr, 21:30
Joerg Schad     Re: Review Request 33646: [Proposal] Follow Google Style Guide for include order completely. Thu, 30 Apr, 17:17
Alexander Rojas       Re: Review Request 33646: [Proposal] Follow Google Style Guide for include order completely. Thu, 30 Apr, 18:45
Re: Review Request 30609: Added a function that reports file size, not following links.
Till Toenshoff   Re: Review Request 30609: Added a function that reports file size, not following links. Wed, 29 Apr, 21:51
Bernd Mathiske     Re: Review Request 30609: Added a function that reports file size, not following links. Thu, 30 Apr, 20:32
Ben Mahler   Re: Review Request 30609: Added a function that reports file size, not following links. Wed, 29 Apr, 23:48
Bernd Mathiske     Re: Review Request 30609: Added a function that reports file size, not following links. Thu, 30 Apr, 19:02
Bernd Mathiske   Re: Review Request 30609: Added a function that reports file size, not following links. Thu, 30 Apr, 20:38
Re: Review Request 32198: Added a not equal operator for json objects.
Till Toenshoff   Re: Review Request 32198: Added a not equal operator for json objects. Thu, 30 Apr, 00:27
Alexander Rojas   Re: Review Request 32198: Added a not equal operator for json objects. Thu, 30 Apr, 00:29
Message list« Previous · 1 · 2 · 3 · Next »Thread · Author · Date
Box list
Oct 201996
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338