mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <>
Subject Re: Review Request 33490: MESOS-2633 Avoid adding duplicate tasks
Date Thu, 30 Apr 2015 21:46:56 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 30, 2015, 9:46 p.m.)

Review request for mesos, Adam B and Joris Van Remoortere.


Replaced original UnaryComparator with a lambda

Repository: mesos


In Framework::addCompletedTask(const Task& task) we did not check
for duplicated tasks, so they could be added more than once.

A simple check has now been added (there still is the issue
of whether the `operator ==` on `Task` is too strict, so as
never to cause a match).

Diffs (updated)

  src/master/framework.cpp PRE-CREATION 



buildbot make check pass


Marco Massenzio

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message