mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 33490: MESOS-2633 Avoid adding duplicate tasks
Date Thu, 30 Apr 2015 21:46:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33490/
-----------------------------------------------------------

(Updated April 30, 2015, 9:46 p.m.)


Review request for mesos, Adam B and Joris Van Remoortere.


Changes
-------

Replaced original UnaryComparator with a lambda


Repository: mesos


Description
-------

In Framework::addCompletedTask(const Task& task) we did not check
for duplicated tasks, so they could be added more than once.

A simple check has now been added (there still is the issue
of whether the `operator ==` on `Task` is too strict, so as
never to cause a match).


Diffs (updated)
-----

  src/master/framework.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/33490/diff/


Testing
-------

buildbot make check pass
http://build.mesosphere.com:5555/builders/dev_test/builds/13


Thanks,

Marco Massenzio


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message