mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.
Date Thu, 30 Apr 2015 21:44:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33376/
-----------------------------------------------------------

(Updated April 30, 2015, 9:44 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Addressed comments


Bugs: MESOS-2633
    https://issues.apache.org/jira/browse/MESOS-2633


Repository: mesos


Description
-------

Created new file framework.cpp containing all the methods' implementations for the `Framework`
class (declared in master/master.hpp)

Declared `operator ==` for Task in type_utils.hpp 
(it was implemented before, but not declared in the header file);

Refactored all the LOG(WARNING) to a single utility method.


Diffs (updated)
-----

  include/mesos/type_utils.hpp 044637481e5405d4d6f61653a9f9386edd191deb 
  src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
  src/master/framework.cpp PRE-CREATION 
  src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd 

Diff: https://reviews.apache.org/r/33376/diff/


Testing
-------

All tests (make check) pass.


Thanks,

Marco Massenzio


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message