mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 32108: Added manual make for readability training source code.
Date Thu, 30 Apr 2015 20:23:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32108/
-----------------------------------------------------------

(Updated April 30, 2015, 1:23 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

The pre-commit hook did not work, because build boit uses commit before configure, etc. happens.
Inserted "readability" as normal build target now. Suggestions?

More examples for naming issues.

Source code license headers.


Repository: mesos


Description
-------

Readability source code now has a Makefile that is generated by bootstrap and configure. "cd
build/readability; make" compiles the sources in "readability/". No linking occurs. This is
just to ensure that we have syntactially correct and type-checked example files.

Slightly rearranged the content of naming_*.cpp and broke out an extra file for whitespace
issues.

Replaces:
https://reviews.apache.org/r/31990/
https://reviews.apache.org/r/31992/


Diffs (updated)
-----

  Makefile.am dcd0cb474944ae9c882e6cbdb64a33b4be5b9083 
  configure.ac 589ae97d0432370b462576cd1985544564893999 
  readability/Makefile.am PRE-CREATION 
  readability/README.md PRE-CREATION 
  readability/naming_comments.cpp PRE-CREATION 
  readability/naming_review.cpp PRE-CREATION 
  readability/whitespace_comments.cpp PRE-CREATION 
  readability/whitespace_review.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/32108/diff/


Testing
-------

cd build/readability; make

Also observed that the pre-commit hook does this as well.


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message