mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 33448: Added Eclipse-specific files to the gitignore list
Date Thu, 30 Apr 2015 00:57:11 GMT


> On April 29, 2015, 7:44 p.m., Joris Van Remoortere wrote:
> > .gitignore-template, lines 29-33
> > <https://reviews.apache.org/r/33448/diff/1/?file=939883#file939883line29>
> >
> >     Are all of these Eclipse specific?
> >     
> >     I'm not familiar with eclipse, but the `.autotools` and `out/` seem like they
are more general?
> >     
> >     If that's the case, let's move them into their own comment block.

.autotools is an Eclipse-specific XML file:
$ cat .autotools 
<?xml version="1.0" encoding="UTF-8"?>
<configurations>
<configuration id="org.eclipse.linuxtools.cdt.autotools.core.configuration.build.505870359">
<option id="configure" value="configure"/>
<option id="configdir" value=""/>
<option id="cache-file" value=""/>
<option id="help" value="false"/>
<option id="no-create" value="false"/>
<option id="quiet" value="false"/>
<option id="version" value="fal...

and on and on.
out/ is the default folder that gets created for the binary files, but if you feel strongly
about it, we can move to ... (please provide suggestion?) 
but, again, this is the .gitignore file - does it really matter?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33448/#review82003
-----------------------------------------------------------


On April 22, 2015, 8:36 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33448/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 8:36 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Eclipse-specific files to the gitignore list
> 
> 
> Diffs
> -----
> 
>   .gitignore-template 1a8e2a8677a29f06ba6386d56537a0013d38821c 
> 
> Diff: https://reviews.apache.org/r/33448/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message