mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.
Date Wed, 29 Apr 2015 21:26:33 GMT


> On April 29, 2015, 9:18 p.m., Till Toenshoff wrote:
> > docs/mesos-c++-style-guide.md, line 93
> > <https://reviews.apache.org/r/33271/diff/4/?file=939734#file939734line93>
> >
> >     Why not using the "```" code-marks instead of the "pre" tag? The former triggers
nice syntax highlighting when viewed with a proper markdown-viewer.

I was following the pattern in the file, but let's use "```" instead! Updating review now.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/#review82025
-----------------------------------------------------------


On April 22, 2015, 6:36 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33271/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 6:36 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael Park, and
Till Toenshoff.
> 
> 
> Bugs: MESOS-2629
>     https://issues.apache.org/jira/browse/MESOS-2629
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow up from r32630.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md de1b93e9f210cd20db2355bd666991339fa4f50b 
> 
> Diff: https://reviews.apache.org/r/33271/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message