mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.
Date Wed, 29 Apr 2015 21:18:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33558/#review82027
-----------------------------------------------------------



docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/33558/#comment132651>

    In some places you use `1: ...` and in others you use `1. ...`. Can we be consistent (also
with the rest of the document)



docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/33558/#comment132652>

    Did we want to indent these 4 more (i.e. 8 total) so that they don't align the same as
the capture list?


- Joris Van Remoortere


On April 28, 2015, 5:33 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33558/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 5:33 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-2669
>     https://issues.apache.org/jira/browse/MESOS-2669
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary. Note that there will be a follow up review which enacts this style in the
code base.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md fe98f90ad0b0f5dd38af97e85062e90cee8de99e 
> 
> Diff: https://reviews.apache.org/r/33558/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message