> On April 26, 2015, 10:40 p.m., Till Toenshoff wrote:
> > Minor nit, please make sure your summary ends with a punctuation. For the description,
we commonly enter "see summary" in cases where that one is descriptive enough for the commit.
Thanks, fixed the dot. The description is actually how post_review generates it.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33531/#review81648
-----------------------------------------------------------
On April 27, 2015, 4:50 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33531/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 4:50 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Till Toenshoff.
>
>
> Bugs: MESOS-2496
> https://issues.apache.org/jira/browse/MESOS-2496
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/logging/flags.cpp c0274424b93094c2f2004663505ee9c71dafd97e
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
>
> Diff: https://reviews.apache.org/r/33531/diff/
>
>
> Testing
> -------
>
> make check + visual inspection of master/slave --help
>
>
> Thanks,
>
> Joerg Schad
>
>
|