mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332)
Date Sat, 25 Apr 2015 01:06:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32660/#review81578
-----------------------------------------------------------



include/mesos/mesos.proto
<https://reviews.apache.org/r/32660/#comment132014>

    i am trying to see if we can flatten this to right inside this message and not use a new
message type and a string id
    
    we can talk about this offline.


- Chi Zhang


On April 24, 2015, 7:42 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32660/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 7:42 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report network isolator statistics on a per container basis (MESOS-2332)
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 466cd82e69665af217d61392b739b9bba16e1e13

>   src/slave/containerizer/isolators/network/port_mapping.cpp ccdc44f465f204f674b859c429ba1a6ada51cd88

>   src/slave/containerizer/mesos/containerizer.hpp fb334e53bc8d73bced402095daddab5e06dc2dd1

>   src/slave/containerizer/mesos/containerizer.cpp ea3b499258b6be4a643d246159a17a0eaeedf904

> 
> Diff: https://reviews.apache.org/r/32660/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message