mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 33040: Expose qdisc statistics from libnl
Date Fri, 24 Apr 2015 22:53:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33040/#review81563
-----------------------------------------------------------



src/linux/routing/queueing/statistics.hpp
<https://reviews.apache.org/r/33040/#comment131984>

    handle.hpp is only used in the implementation?



src/linux/routing/queueing/statistics.cpp
<https://reviews.apache.org/r/33040/#comment131981>

    not sure if auto is whitelisted, as much as I'd like to embrace it. 
    
    @jieyu could you comment on this?



src/linux/routing/queueing/statistics.cpp
<https://reviews.apache.org/r/33040/#comment131982>

    nit: I don't think the style guide likes abbr. names such as ptr. Could you adjust?



src/linux/routing/queueing/statistics.cpp
<https://reviews.apache.org/r/33040/#comment131979>

    Every single use of i is casted before used, wondering if you pick a different type for
i, could you reduce some casting here. also, I think the c++ styple casts are preferred.



src/linux/routing/queueing/statistics.cpp
<https://reviews.apache.org/r/33040/#comment131978>

    nit: const string name



src/linux/routing/queueing/statistics.cpp
<https://reviews.apache.org/r/33040/#comment131983>

    should we ignore if tcName returns a ""?



src/linux/routing/queueing/statistics.cpp
<https://reviews.apache.org/r/33040/#comment131977>

    nit: kill the whitespace in front of the lines?



src/linux/routing/queueing/statistics.cpp
<https://reviews.apache.org/r/33040/#comment131976>

    nit: I thought we stopped using non-pod static types anymore?



src/linux/routing/queueing/statistics.cpp
<https://reviews.apache.org/r/33040/#comment131980>

    nit: just s/std:string/string/g since you have the 'using std::string;' above?


- Chi Zhang


On April 24, 2015, 7:28 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33040/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose qdisc statistics from libnl
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93c7c8a 
>   src/linux/routing/queueing/fq_codel.cpp 02ad8df 
>   src/linux/routing/queueing/ingress.cpp 47c7337 
>   src/linux/routing/queueing/internal.hpp 7c6c4d3 
>   src/linux/routing/queueing/statistics.hpp PRE-CREATION 
>   src/linux/routing/queueing/statistics.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp 7cc3b57 
> 
> Diff: https://reviews.apache.org/r/33040/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message