mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 33414: Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.
Date Fri, 24 Apr 2015 19:40:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33414/#review81532
-----------------------------------------------------------

Ship it!


Perhaps add a test that verifies unknown orphans are cleaned up?


src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/33414/#comment131927>

    s/that//



src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/33414/#comment131924>

    s/destory/destroy


- Ian Downes


On April 21, 2015, 2:46 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33414/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 2:46 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Bugs: MESOS-2367
>     https://issues.apache.org/jira/browse/MESOS-2367
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4

>   src/slave/containerizer/mesos/containerizer.cpp e4136095fca55637864f495098189ab3ad8d8fe7

> 
> Diff: https://reviews.apache.org/r/33414/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message