mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 33412: Made the launcher recover interface to return a set of orphan containers.
Date Fri, 24 Apr 2015 19:39:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33412/#review81542
-----------------------------------------------------------

Ship it!


Ship It!

- Ian Downes


On April 21, 2015, 2:43 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33412/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 2:43 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Bugs: MESOS-2367
>     https://issues.apache.org/jira/browse/MESOS-2367
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made the launcher recover interface to return a set of orphan containers.
> 
> The idea is to report orphan containers to the containerizer so that the containerizer
can initiate the destroy of the orphan containers asynchronously without blocking (or failing)
the recovery.
> 
> In this patch, the launcher always returns an empty set of orphan containers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/launcher.hpp 95a7f764e819503eb94cc8bf09eeead29247a544 
>   src/slave/containerizer/launcher.cpp eb798fadfb9b50e08ffaeae1da56129a1745fbab 
>   src/slave/containerizer/linux_launcher.hpp 60082c7eb8b77330911ac4fa38cc9ba795fc4051

>   src/slave/containerizer/linux_launcher.cpp b176ac126657ed8291dd817ceb61c04a68ff1d42

>   src/tests/launcher.hpp 81ae95c91b5baf11bac3da0c9317981242accd37 
> 
> Diff: https://reviews.apache.org/r/33412/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message