mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 33040: Expose qdisc statistics from libnl
Date Fri, 24 Apr 2015 19:25:31 GMT


> On April 24, 2015, 6:09 p.m., Jie Yu wrote:
> > src/linux/routing/queueing/internal.hpp, lines 154-160
> > <https://reviews.apache.org/r/33040/diff/7/?file=941075#file941075line154>
> >
> >     Why this change? What if in the future we have two  versions of fq_codel qdiscs.
Only using the name to distinguish seems to be insufficient. Could you please revert this
change?
> 
> Paul Brett wrote:
>     The old method of using the handle to find the qdisc does not work in practice. 
The hard coded handles specified in the disciplines are not used for fq_codel (or htb for
which we do not track the handle), but searching from the root by name always works because
the first discipline of the correct type we find will have the statistics.

Are you refering to the case where there's already a root qdisc installed on the host and
it's handle does not match the hard coded handle we use?

We can still keep the decode function here. You just need to tune the decode function for
fq_codel qdisc (like removing the handle equality check).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33040/#review81503
-----------------------------------------------------------


On April 24, 2015, 5:46 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33040/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 5:46 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose qdisc statistics from libnl
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/linux/routing/queueing/fq_codel.hpp 4f67ab7d64afea96a07dfcf36769a9c667749a00 
>   src/linux/routing/queueing/fq_codel.cpp 02ad8df7814c0e549a9ca9aef39777684e6abdcb 
>   src/linux/routing/queueing/handle.hpp 2725d0794ca29ad5dc1b0148d0f68b90ce8b8369 
>   src/linux/routing/queueing/ingress.hpp b323a7f6daed828327d6d9e9740df81582e0ba2b 
>   src/linux/routing/queueing/ingress.cpp 47c73376097d70819defdee31a6d1e446df6b8ba 
>   src/linux/routing/queueing/internal.hpp 7c6c4d3d960b9a4bf44dcf482212317522353d69 
>   src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba 
> 
> Diff: https://reviews.apache.org/r/33040/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message