mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 32999: Added a document for engineering principles and practices.
Date Thu, 23 Apr 2015 23:04:43 GMT


> On April 20, 2015, 7:32 p.m., Niklas Nielsen wrote:
> > docs/engineering-principles-and-practices.md, line 7
> > <https://reviews.apache.org/r/32999/diff/1/?file=921216#file921216line7>
> >
> >     Long lines :) Do you think it is worth applying the 80 col style? If so, we
should do a scan.
> >     
> >     s/**high quality**, **robust** code/**high quality** and **robust** code/?

Thanks! Line-wrapped these manually, would love to automate our markdown formatting.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32999/#review80796
-----------------------------------------------------------


On April 9, 2015, 12:30 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32999/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 12:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, and Vinod
Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a document for engineering principles and practices.
> 
> 
> Diffs
> -----
> 
>   docs/engineering-principles-and-practices.md PRE-CREATION 
>   docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 
> 
> Diff: https://reviews.apache.org/r/32999/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message