mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.
Date Thu, 23 Apr 2015 17:35:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32140/#review81342
-----------------------------------------------------------



src/common/resources.cpp
<https://reviews.apache.org/r/32140/#comment131681>

    The DiskInfo should match at this point. So
    ```
    if (left.has_disk() && left.disk().has_persistence())
    ```
    should be sufficient.



src/common/resources.cpp
<https://reviews.apache.org/r/32140/#comment131682>

    See my comments in https://reviews.apache.org/r/32150/
    
    Can we move this to master validation? Thoughts?



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32140/#comment131688>

    Move this to src/tests/mesos.hpp close to createPersistentVolume?



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32140/#comment131689>

    Nits. Just to be consistent, please use the same style:
    ```
    EXPECT_NONE(Resources::validate(createReservedResource(
        "cpus", ..., ..., ...));
    ```



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32140/#comment131684>

    Please move '{' to the next line.



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32140/#comment131685>

    Ditto.



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32140/#comment131690>

    Mind splitting into two tests?
    
    AdditionStaticallyReserved
    AdditionDynamicallyReserved



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32140/#comment131686>

    Ditto.


- Jie Yu


On April 22, 2015, 8:36 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32140/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 8:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-2476
>     https://issues.apache.org/jira/browse/MESOS-2476
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `Resource::ReservationInfo` was introduced in [r32139](https://reviews.apache.org/r/32139).
We need to consider it in our `Resources` class implementation.
> 
> ### `Resources::flatten`
> 
> `flatten` is used as the utility function to cross reservation boundaries without affecting
the given resources. Since the reservation is now specified by the (`role`, `reservation`)
pair, `flatten` needs to consider `ReservationInfo` as well.
> 
> ### `Resources::validate`
> 
> If `role == "*"`, then `reservation` field must not be set.
> 
> ### `Resources` comparators
> 
> `operator==`, `addable` and `substractable` need to test for `ReservationInfo` as well.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 56affd45e1e71e96ff5778b43271f81b9b9a9e4d 
>   src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 
>   src/tests/mesos.hpp 4294e28f904161b473c0cfa7feea4eaa4e7c97e3 
>   src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415 
> 
> Diff: https://reviews.apache.org/r/32140/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message