mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.
Date Thu, 23 Apr 2015 16:26:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81308
-----------------------------------------------------------



include/mesos/mesos.proto
<https://reviews.apache.org/r/33296/#comment131635>

    Check the comment formatting, please.



include/mesos/mesos.proto
<https://reviews.apache.org/r/33296/#comment131637>

    Might be a good idea to add a comment on why this message name is using plural even though
it currently contains only a single rule.



include/mesos/mesos.proto
<https://reviews.apache.org/r/33296/#comment131647>

    I am unsure if `include/mesos.proto` is the _right_ place for this given that this message
does not need to get exposed. As this forms the base of more definitions to come, I would
like to propose adding a new .proto file specifically for this. How about using  `src/messages/firewall.proto`
& `src/messages/firewall.hpp` with the package / namespace `mesos.internal.firewall` and
use `Rules` as the name instead?
    
    So now we have `process::FirewallRule` and `mesos::FirewallRules` (proto message). That
seems a bit unfortunate, especially due to the fact hat `FirewallRules` is __not__ composed
by repeated `FirewallRule`.
    How about `mesos::internal::firewall::Rules` (proto message) and `process::FirewallRule`
instead? Note however that I feel rather unsure about the best way here.



src/master/flags.cpp
<https://reviews.apache.org/r/33296/#comment131638>

    s/FirewallRule/FirewallRules/



src/master/main.cpp
<https://reviews.apache.org/r/33296/#comment131639>

    


- Till Toenshoff


On April 22, 2015, 2:36 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 2:36 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2620
>     https://issues.apache.org/jira/browse/MESOS-2620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 
>   include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 
>   src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc 
>   src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a 
>   src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90 
>   src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99 
>   src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 
>   src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 
>   src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2 
> 
> Diff: https://reviews.apache.org/r/33296/diff/
> 
> 
> Testing
> -------
> 
> make check and manual tests.
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message