mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 32843: Updated KILL to include SlaveID.
Date Wed, 22 Apr 2015 22:20:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32843/#review81222
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/32843/#comment131473>

    Does this variable buy us much vs `kill.task_id()`? For example, we don't do this for
framework->id(), I'm guessing you did it to be similar to slaveId?



src/master/master.cpp
<https://reviews.apache.org/r/32843/#comment131471>

    You may want to avoid taking a const reference to the temporary here?



src/master/master.cpp
<https://reviews.apache.org/r/32843/#comment131475>

    Will this be a BadRequest so schedulers can detect the issue? Maybe a TODO?



src/master/master.cpp
<https://reviews.apache.org/r/32843/#comment131474>

    Whoops, remove the semi-colon?



src/tests/scheduler_tests.cpp
<https://reviews.apache.org/r/32843/#comment131476>

    Did you want this extra newline?


- Ben Mahler


On April 22, 2015, 9:40 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32843/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 9:40 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1127
>     https://issues.apache.org/jira/browse/MESOS-1127
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Having SlaveID will help us do better reconciliation when the task is not found. Also,
updated master to handle Call::Kill.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 
>   src/master/master.hpp 550d2c50cd01aa5830a7e7e03ab4a0240c221b15 
>   src/master/master.cpp f3462d15005e24ab28e8265484b0d3810f21bd47 
>   src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a 
>   src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 
> 
> Diff: https://reviews.apache.org/r/32843/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message