mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 33452: Fixed the python bindings to use implicit acknoweldgements by default.
Date Wed, 22 Apr 2015 21:53:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33452/
-----------------------------------------------------------

Review request for mesos, Alexander Rojas and Vinod Kone.


Bugs: MESOS-2643
    https://issues.apache.org/jira/browse/MESOS-2643


Repository: mesos


Description
-------

See [MESOS-2643](https://issues.apache.org/jira/browse/MESOS-2643) and [this thread](http://www.mail-archive.com/dev@mesos.apache.org/msg32291.html)
for the context.


Diffs
-----

  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp b0a5ef49ba7ff7cf52d2ec649045a48f7f692014


Diff: https://reviews.apache.org/r/33452/diff/


Testing
-------

Tested manually through `test_framework.py`.

I removed the explicit argument passing and ran with and without this patch to ensure the
default is picked up correctly.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message