mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 32844: Added SUBSCRIBE call and SUBSCRIBED event.
Date Wed, 22 Apr 2015 21:41:49 GMT


> On April 20, 2015, 11:18 p.m., Ben Mahler wrote:
> > include/mesos/scheduler/scheduler.proto, line 117
> > <https://reviews.apache.org/r/32844/diff/2/?file=936880#file936880line117>
> >
> >     Might help to have a hint pointing to the framework id semantics:
> >     
> >     ```
> >     SUBSCRIBE = 1;  // See 'framework_info' below.
> >     ```

done.


> On April 20, 2015, 11:18 p.m., Ben Mahler wrote:
> > src/examples/low_level_scheduler_libprocess.cpp, lines 126-127
> > <https://reviews.apache.org/r/32844/diff/2/?file=936881#file936881line126>
> >
> >     Maybe just "Subscribed with ID X"?

done.


> On April 20, 2015, 11:18 p.m., Ben Mahler wrote:
> > src/examples/low_level_scheduler_pthread.cpp, lines 147-148
> > <https://reviews.apache.org/r/32844/diff/2/?file=936882#file936882line147>
> >
> >     Ditto here.

done.


> On April 20, 2015, 11:18 p.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 1564-1567
> > <https://reviews.apache.org/r/32844/diff/2/?file=936883#file936883line1564>
> >
> >     TODO for implementing this? I assume you held off because of the non-trivial
streaming related changes needed?

done. added a top level TODO for all unimplemented calls.


> On April 20, 2015, 11:18 p.m., Ben Mahler wrote:
> > src/scheduler/scheduler.cpp, lines 542-548
> > <https://reviews.apache.org/r/32844/diff/2/?file=936884#file936884line542>
> >
> >     This isn't yours, but is this right? We're looking at SUBSCRIBED events when
the master is `None`?

doesn't seem correct. fixed.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32844/#review80855
-----------------------------------------------------------


On April 20, 2015, 8:03 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32844/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 8:03 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1127
>     https://issues.apache.org/jira/browse/MESOS-1127
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of REGISTER and REREGISTER we now just have SUBSCRIBE. Similarly, instead of
REGISTERED and REREGISTERED there is only SUBSCRIBED. This will simplify a scheduler's registration
semantics.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 
>   src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997

>   src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d

>   src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc 
>   src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a 
>   src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 
> 
> Diff: https://reviews.apache.org/r/32844/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message