lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [lucenenet] NightOwl888 commented on issue #360: AnalyzingInfixSuggester Index Storage
Date Wed, 27 Jan 2021 17:37:36 GMT

NightOwl888 commented on issue #360:

   Sure, this is something that both looks easy and might not be as easy as it looks :grin:.
   Please make sure it is clear (with either comments or c# sections) which parts are ported
from after Lucene 4.8.0. By convention, we use `\\ LUCENENET specific - ` followed by a brief
note about how we have diverged from Lucene 4.8.0.
   Those extra constructor parameters look innocuous enough until you think about the fact
that it is a breaking constructor API change. Please add another ctor overload while preserving
both the signature and behavior of the original 4.8.0 constructor, just to make sure the changes
are completely compatible with 4.8.0-ported code.
   > Note: Microsoft almost never uses optional parameters in their code, so that is something
we usually try to avoid.
   By the same measure, tests should be set up to ensure exact 4.8.0 compatibility as well
as for testing the complete functionality of these new changes, and we should ensure that
these 2 groups of tests are clearly delineated in the code with a clear path forward when
the code is upgraded beyond 4.8.0.
   Fortunately, adding a `Commit()` method is not a breaking API change, so there is no issue
with simply adding it on top of the existing API.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message