lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 opened a new pull request #386: Fixes #296 - Remove Equals() from Lucene.Net.Util.Automaton.State
Date Thu, 05 Nov 2020 03:58:17 GMT

NightOwl888 opened a new pull request #386:
URL: https://github.com/apache/lucenenet/pull/386


   It took awhile to track it down, but with a working failure project (thanks @wilson556)
and confirmation that the problem started between 4.8.0-beta00007 and 4.8.0-beta00008 the
problem was traced to https://github.com/apache/lucenenet/commit/e1ead061df6ab5371979040ae8071b1bf8b18070.
   
   It turns out that this was being caused by a subtle change from using reference equality
to implementing an `Equals()` method, which was comparing the `id` value. The presumption
that the `id` would be unique. It turns out that the unique identifier is the object reference
and `id` might have collisions.
   
   Fixes #296.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message