lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] theolivenbaum commented on pull request #373: Remove delegate based debugging assert
Date Mon, 19 Oct 2020 13:46:09 GMT

theolivenbaum commented on pull request #373:
URL: https://github.com/apache/lucenenet/pull/373#issuecomment-712167372


   @eladmarg @NightOwl888 think I'm done with the changes, for reviewing, worth checking just
the final diff against master as I did some cleanup to make the final diff smaller.
   There should be no logic changes now, and this should work also in the case where generating
the message would throw if the assert is false.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message