lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on pull request #369: Add fork me on GitHub
Date Sat, 17 Oct 2020 16:23:22 GMT

NightOwl888 commented on pull request #369:
URL: https://github.com/apache/lucenenet/pull/369#issuecomment-711039054


   Thanks. The color scheme looks great.
   
   ## Build
   
   When running the website build script, it is no longer processing all of the tags correctly
so the home page looks like this:
   
   ![image](https://user-images.githubusercontent.com/1538288/96346665-3f366d80-10c7-11eb-9f0a-310cbe63c7b1.png)
   
   DocFx doesn't process markdown files that contain plain HTML (`index.md`, `issue-tracker.md`,
etc). I confirmed this by removing the `span` from `index.md`. However, that only fixes the
home page. When the `span` is removed from other pages, the ribbon is no longer visible.
   
   I don't have a lot of experience with DocFx, but I believe that instead of putting the
`span` tag in Markdown, you need to put it inside a partial file (for example,  `\websites\site\lucenenet\partials\head.tmpl.partial`
and `\websites\site\lucenenet\partials\head.tmpl.partial`). I believe in this case you may
need to generate an additional `.partial` file to put the HTML into the body of every page,
rather than in the header. There is a [quick guide to customizing a docfx site](https://www.cazzulino.com/customize-docfx.html),
or if you need more detailed info, I suggest looking at the [DocFx Manual](https://dotnet.github.io/docfx/tutorial/docfx.exe_user_manual.html).
   
   @Shazwazza - Can you provide some additional insights?
   
   ## Layout
   
   On the 2 largest resolution viewports, the ribbon overlaps the rightmost menu item when
resizing the browser. Could we perhaps add some padding to the right side to keep all of the
menu items from being hidden?
   
   ![image](https://user-images.githubusercontent.com/1538288/96347735-dc94a000-10cd-11eb-94ff-f945348c774f.png)
   ![image](https://user-images.githubusercontent.com/1538288/96347742-e6b69e80-10cd-11eb-8af8-c9244e0a0e44.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message