From dev-return-11723-apmail-lucenenet-dev-archive=lucenenet.apache.org@lucenenet.apache.org Tue Sep 22 15:01:44 2020 Return-Path: X-Original-To: apmail-lucenenet-dev-archive@www.apache.org Delivered-To: apmail-lucenenet-dev-archive@www.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 4EF8F192FB for ; Tue, 22 Sep 2020 15:01:44 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id F2B241238F4 for ; Tue, 22 Sep 2020 15:01:43 +0000 (UTC) Received: (qmail 30681 invoked by uid 500); 22 Sep 2020 15:01:43 -0000 Delivered-To: apmail-lucenenet-dev-archive@lucenenet.apache.org Received: (qmail 30648 invoked by uid 500); 22 Sep 2020 15:01:43 -0000 Mailing-List: contact dev-help@lucenenet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucenenet.apache.org Delivered-To: mailing list dev@lucenenet.apache.org Received: (qmail 30636 invoked by uid 99); 22 Sep 2020 15:01:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2020 15:01:43 +0000 From: =?utf-8?q?GitBox?= To: dev@lucenenet.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Blucenenet=5D_theolivenbaum_commented_on_issue_=233?= =?utf-8?q?46=3A_Remove_Debugging=2EAssertsEnabled?= Message-ID: <160078690324.32230.14362698839151102699.asfpy@gitbox.apache.org> Date: Tue, 22 Sep 2020 15:01:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: theolivenbaum commented on issue #346: URL: https://github.com/apache/lucenenet/issues/346#issuecomment-696779612 The only place I saw this being set so far is under Lucene.Net.Index.CheckIndex, so I added a conditional compilation there too: https://github.com/apache/lucenenet/pull/345/commits/5a14eaaf8190d81755f48981552ebe16ee046b80#diff-3f750f45c88050fc4fbd6a09ee4c638cR54 But I have unloaded some projects (VS was too slow with everything loaded), so might be missing something... In any case, unless there is a need for this as a settable value in release mode, probably good to remove it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org